[PATCH] D72423: [DemandedBits] Improve accuracy of Add propagator

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 9 02:26:35 PST 2020


lebedev.ri added a comment.

In D72423#1811604 <https://reviews.llvm.org/D72423#1811604>, @rrika wrote:

> By exhaustive test you mean an .ll file, or a program looping over all values?


No, a unit test.
See `llvm/unittests/IR/ConstantRangeTest.cpp` for inspiration.

> In the process of writing this I found a mistake (the final '+1' only applies to additions, not subtractions) so I'll edit the patch in a bit.

(That's why such a test should exist)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72423/new/

https://reviews.llvm.org/D72423





More information about the llvm-commits mailing list