[PATCH] D70286: Merge memtag instructions with adjacent stack slots.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis marked an inline comment as done.
eugenis added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.cpp:457
+  if (MI.getOpcode() == AArch64::STGloop || MI.getOpcode() == AArch64::STZGloop)
+    return MI.getOperand(1).getReg();
+  else
----------------
Hmm, there is actually a check against this in the verifier:

    *** Bad machine code: Tied use must be a register ***
    - function:    stg_alloca17
    - basic block: %bb.0 entry (0x20076710580)
    - instruction: early-clobber %0:gpr64common, early-clobber %1:gpr64sp = STGloop 272, %stack.0.a :: (store 272 into %ir.a, align 16)
    - operand 3:   %stack.0.a
    
    http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/21481/steps/test-check-all/logs/stdio

I've reverted the change for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70286/new/

https://reviews.llvm.org/D70286