[PATCH] D72224: [LegalizeVectorOps] Improve handling of multi-result operations.

[Craig Topper via Phabricator via llvm-commits]

craig.topper marked an inline comment as done.
craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp:884
+    if (SDValue Tmp = ExpandFSUB(Op))
+      Results.push_back(Tmp);
+    return;
----------------
uweigand wrote:
> It's a bit odd to hard-code that **some** expanders may return a null SDValue and others may not.  It may be preferable to just pass the Results vector through.
Agreed. I was trying to minimize the changes to the handlers in this patch to keep the size down. I'm going to do a follow up patch to pass SDNode *N instead of Op to all the handlers. I can push Results while I'm doing that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72224/new/

https://reviews.llvm.org/D72224