[PATCH] D69835: Add options for PPC to enable/disable using non-volatile CR

[Yi-Hong Lyu via Phabricator via llvm-commits]

Yi-Hong.Lyu added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.td:369
+    const PPCFunctionInfo *FI = MF.getInfo<PPCFunctionInfo>();
+    return MF.getSubtarget<PPCSubtarget>().isELFv2ABI() && FI->isNonVolatileCRDisabled();
+  }];
----------------
Why do you NOT introduce a temp variable in the former condition but introduce one in the later one? I would suggest choose one style and use that uniformly.


================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.td:379
+    const PPCFunctionInfo *FI = MF.getInfo<PPCFunctionInfo>();
+    return MF.getSubtarget<PPCSubtarget>().isELFv2ABI() && FI->isNonVolatileCRDisabled();
+  }];
----------------
Same as above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69835/new/

https://reviews.llvm.org/D69835