[PATCH] D72197: [MC][ELF] Emit a relocation if target is defined in the same section and is non-local

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

If I could summarise the comments so far:

- There is some concern that this is not the full solution and there maybe other things that can break interposing.
- The response is that fixing the assembler will be a necessary part of that work.
- There maybe some extra via-PLT calls in shared libraries if -ffunction-sections is not used, but these can be mitigated by giving the symbols non-default visibility, and in any case these would exist with -ffunction-sections.

I'm personally in favour of the change, I'd like to see if there any firm objections from others?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72197/new/

https://reviews.llvm.org/D72197