[PATCH] D72397: m_Constant()

[lorenzo chelini via Phabricator via llvm-commits]

chelini updated this revision to Diff 236837.
chelini added a comment.

Introduce [mlir] tag in the commit message. Modify the constant_op_binder class as suggested by Alex. Specifically, introduce a class constructor with zero arguments which sets bind_value to `nullptr`. In the `match` method, insert an early exit if we match a constantOp, but we don't need to bind to any attribute value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72397/new/

https://reviews.llvm.org/D72397

Files:
  mlir/include/mlir/IR/Matchers.h
  mlir/lib/IR/Builders.cpp
  mlir/test/IR/test-matchers.mlir
  mlir/test/lib/IR/TestMatchers.cpp


Index: mlir/test/lib/IR/TestMatchers.cpp
===================================================================
--- mlir/test/lib/IR/TestMatchers.cpp
+++ mlir/test/lib/IR/TestMatchers.cpp
@@ -126,12 +126,15 @@
   auto a = m_Val(f.getArgument(0));
   FloatAttr floatAttr;
   auto p = m_Op<MulFOp>(a, m_Op<AddFOp>(a, m_Constant(&floatAttr)));
+  auto p1 = m_Op<MulFOp>(a, m_Op<AddFOp>(a, m_Constant()));
   // Last operation that is not the terminator.
   Operation *lastOp = f.getBody().front().back().getPrevNode();
   if (p.match(lastOp))
     llvm::outs()
         << "Pattern add(add(a, constant), a) matched and bound constant to: "
         << floatAttr.getValueAsDouble() << "\n";
+  if (p1.match(lastOp))
+    llvm::outs() << "Pattern add(add(a, constant), a) matched\n";
 }
 
 void TestMatchers::runOnFunction() {
Index: mlir/test/IR/test-matchers.mlir
===================================================================
--- mlir/test/IR/test-matchers.mlir
+++ mlir/test/IR/test-matchers.mlir
@@ -40,3 +40,4 @@
 
 // CHECK-LABEL: test2
 //       CHECK:   Pattern add(add(a, constant), a) matched and bound constant to: 1.000000e+00
+//       CHECK:   Pattern add(add(a, constant), a) matched
Index: mlir/lib/IR/Builders.cpp
===================================================================
--- mlir/lib/IR/Builders.cpp
+++ mlir/lib/IR/Builders.cpp
@@ -342,8 +342,7 @@
   };
 
   // If this operation is already a constant, there is nothing to do.
-  Attribute unused;
-  if (matchPattern(op, m_Constant(&unused)))
+  if (matchPattern(op, m_Constant()))
     return cleanupFailure();
 
   // Check to see if any operands to the operation is constant and whether
Index: mlir/include/mlir/IR/Matchers.h
===================================================================
--- mlir/include/mlir/IR/Matchers.h
+++ mlir/include/mlir/IR/Matchers.h
@@ -56,6 +56,8 @@
   /// Creates a matcher instance that binds the constant attribute value to
   /// bind_value if match succeeds.
   constant_op_binder(AttrT *bind_value) : bind_value(bind_value) {}
+  /// Creates a matcher instance that doesn't bind if match succeeds.
+  constant_op_binder() : bind_value(nullptr) {}
 
   bool match(Operation *op) {
     if (op->getNumOperands() > 0 || op->getNumResults() != 1)
@@ -66,6 +68,8 @@
     SmallVector<OpFoldResult, 1> foldedOp;
     if (succeeded(op->fold(/*operands=*/llvm::None, foldedOp))) {
       if (auto attr = foldedOp.front().dyn_cast<Attribute>()) {
+        if (!bind_value)
+          return true;
         if ((*bind_value = attr.dyn_cast<AttrT>()))
           return true;
       }
@@ -196,6 +200,11 @@
 
 } // end namespace detail
 
+/// Matches a value from a constant foldable operation.
+inline detail::constant_op_binder<Attribute> m_Constant() {
+  return detail::constant_op_binder<Attribute>();
+}
+
 /// Matches a value from a constant foldable operation and writes the value to
 /// bind_value.
 template <typename AttrT>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72397.236837.patch
Type: text/x-patch
Size: 2944 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200108/9f754b5a/attachment.bin>