[PATCH] D72215: [AArch64] Add function attribute "patchable-function-entry" to add NOPs at function entry

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 8 00:23:42 PST 2020


MaskRay updated this revision to Diff 236772.
MaskRay added a comment.

I think GCC's __patchable_function_entries has severe design flaws.
I try to address these problems.

Will update this comment soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72215/new/

https://reviews.llvm.org/D72215

Files:
  llvm/include/llvm/CodeGen/AsmPrinter.h
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/CodeGen/PatchableFunction.cpp
  llvm/lib/IR/Verifier.cpp
  llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp
  llvm/test/CodeGen/AArch64/patchable-function-entry.ll
  llvm/test/Verifier/invalid-patchable-function-entry.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72215.236772.patch
Type: text/x-patch
Size: 7992 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200108/7e27b5b0/attachment.bin>


More information about the llvm-commits mailing list