[PATCH] D72303: [BranchAlign] Compiler support for suppressing branch align

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 7 23:20:36 PST 2020


skan added inline comments.


================
Comment at: llvm/lib/Target/X86/X86MCInstLower.cpp:1151
+  NoAutoPaddingScope(MCStreamer &OS)
+    : OS(OS) {
+    OldAllowAutoPadding = OS.getAllowAutoPadding();
----------------
`NoAutoPaddingScope(MCStreamer &OS) : OS(OS) {`

I recommend running command like `git diff -U0 --no-color HEAD^ | clang-format-diff.py -i -p1` to format the patch.



================
Comment at: llvm/lib/Target/X86/X86MCInstLower.cpp:1155-1157
+  ~NoAutoPaddingScope() {
+    changeAndComment(OldAllowAutoPadding);
+  }
----------------
keep the code in one line


================
Comment at: llvm/lib/Target/X86/X86MCInstLower.cpp:1325
   SMShadowTracker.emitShadowPadding(*OutStreamer, getSubtargetInfo());
-
+  
   auto &Ctx = OutStreamer->getContext();
----------------
Remove blank here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72303/new/

https://reviews.llvm.org/D72303





More information about the llvm-commits mailing list