[PATCH] D69066: Add support for intrinsic llvm.ppc.eieio

Anil Mahmud via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 7 11:21:38 PST 2020


anil9 marked an inline comment as done.
anil9 added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:2204
 
+// We used to have EIEIO as value but E[0-9A-Z] is a reserved name
+def EnforceIEIO : XForm_24_eieio<31, 854, (outs), (ins),
----------------
steven.zhang wrote:
> Please set the has side effect bit to make it clear.
The purpose of this patch is to expose this instruction using a built in function. You are correct that using the hasSideEffects bit will make it clear, but I checked that there are a lot of synchronization instructions without the hasSideEffects bit set, I think all of them should be handled together in a separate patch. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69066/new/

https://reviews.llvm.org/D69066





More information about the llvm-commits mailing list