[PATCH] D71733: [NFC][InlineCost] Factor cost modeling out of CallAnalyzer traversal.

[Easwaran Raman via llvm-commits]

Sorry for the delay. The stated intention is to keep the legality part in
CallAnalyzer and move the benefit part to InlineCostCallAnalyzer.  But if
you consider any of the visit methods in CallAnalyzer, they actually
compute the benefit - tells whether the instruction can be simplified or
removed by inlining the callee. So what is the division of work
between CallAnalyzer and InlineCostCallAnalyzer?

On Mon, Jan 6, 2020 at 9:07 AM David Li via Phabricator <
reviews at reviews.llvm.org> wrote:

> davidxl added a comment.
>
> this looks good to me. Easwaran, do you have any comments on the
> refactoring?
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D71733/new/
>
> https://reviews.llvm.org/D71733
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200107/8ebdd7a9/attachment.html>