[PATCH] D72300: [DAGCombiner] reduce shuffle of concat of same vector

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 7 05:41:25 PST 2020


spatel added a comment.

In D72300#1807578 <https://reviews.llvm.org/D72300#1807578>, @RKSimon wrote:

> Why doesn't partitionShuffleOfConcats catch this?


It's not exactly the pattern that function is looking for:

  // Tries to turn a shuffle of two CONCAT_VECTORS into a single concat,
  // or turn a shuffle of a single concat into simpler shuffle then concat.

I did consider putting this block into that helper since it's similar, but I didn't see any real shared code savings in the pattern matching. I can still move it inside there for better organization of folds.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72300/new/

https://reviews.llvm.org/D72300





More information about the llvm-commits mailing list