[PATCH] D72031: [Scheduling] Create the missing dependency edges for store cluster

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

This adds new dependencies, hence I think it would be good to gather code size/perf numbers with this change for some impacted targets (e.g. AArch64) to be reasonably sure that there are no unexpected knock-on effects.



================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:1598
+        // do not need to be copied from SUa to SUb since no one will depend
+        // on stores.
+        for (const SDep &Pred : SUb->Preds) {
----------------
I may be missing something, but IIRC stores could have other memory operations as successors, e.g. because to enforce an ordering between aliasing memory operations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72031/new/

https://reviews.llvm.org/D72031