[PATCH] D72313: [llvm-symbolizer]Fix printing of malformed address values not passed via stdin

[Xuanda Yang via Phabricator via llvm-commits]

TH3CHARLie added a comment.

In D72313#1807564 <https://reviews.llvm.org/D72313#1807564>, @jhenderson wrote:

> In D72313#1807560 <https://reviews.llvm.org/D72313#1807560>, @TH3CHARLie wrote:
>
> > Well, if so, doesn't it duplicates what has been tested in `sym.test`?
>
>
> Yes, but sym.test is not a very good test as it tries to test too many different things at once, which means it's hard to actually tell what it's testing or to maintain the test. I'd like to split it up/rewrite it/delete it etc at some point, although it's not high on my priority list. If we keep adding things to that test, it will actually make things worse. By putting this testing in the other test case, we have all our testing for this piece of functionality (i.e. what to do about unknown addresses) in one place, making it easy to find etc.
>
> Does that make sense?


Thanks for the explanation! Now it's much more clear to me


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72313/new/

https://reviews.llvm.org/D72313