[PATCH] D71794: [ELF] Don't special case weak symbols for pie with no shared objects

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

Apologies for the delay in responding, the original came in when I was on vacation.

- Am I correct in thinking that the extra dynamic symbols that will result with -pie and no shared libraries are just wasted space, but won't cause anything to happen at run time as there are no dynamic relocations generated against them?
- The main argument for removing is that this our ld.bfd is ad-hoc and this part doesn't help much, removing it would simplify here and permit a simplification in D71795 <https://reviews.llvm.org/D71795>. Is there a plan beyond D71795 <https://reviews.llvm.org/D71795> to more closely follow ld.bfd behaviour, or is this just an area where we expect cosmetic inconsistencies?

At the moment I'm happy to go ahead with this if we've got a good idea of what our desired end-goal is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71794/new/

https://reviews.llvm.org/D71794