[PATCH] D72115: [TSan] Remove side effects from ThreadTid

[Dmitry Vyukov via Phabricator via llvm-commits]

dvyukov added a comment.

Hi Julian,

Why ThreadTid and FindThreadByUid should be free of side effects? What is the problem you are trying to solve?
I have very worrying feelings about this piece of code. One does not simply shuffle lines here :)
I think it had something to do with races between join and user_id reuse. Are all linux tests reliably pass with this change? Please track history regarding why this line was added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72115/new/

https://reviews.llvm.org/D72115