[PATCH] D69103: Backend for NEC SX-Aurora

[Simon Moll via Phabricator via llvm-commits]

simoll marked an inline comment as done.
simoll added a comment.

Thanks for the review. This patch has been simmering for a while. I'll wait until Thursday to commit this to allow others to chime in.



================
Comment at: llvm/lib/Target/VE/VETargetMachine.cpp:30
+  // Use ELF mangling
+  Ret += "-m:e";
+
----------------
arsenm wrote:
> I think just having a single string would be better unless you're planning on adding checks to control these, but it's not important
We will add vector type alignments in the forthcoming patches. With the DL string spread out over multiple lines those appear more cleanly in the diff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69103/new/

https://reviews.llvm.org/D69103