[PATCH] D72226: [PM][CGSCC] API for outlined ref edges

Brian Gesiak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 6 21:09:46 PST 2020


modocache updated this revision to Diff 236503.
modocache added a comment.

I updated this patch such that it can address the underlying problem encountered by the coro-split pass in D71899 <https://reviews.llvm.org/D71899>: we need a method of inserting new ref edges into an existing call graph, whereas currently the `CallGraphUpdater` only allows the insertion of call edges. I don't know if there's any use for such an API in the old CallGraph, so I left that unimplemented. I also considered simply adding this functionality as a member function on `LazyCallGraph` or one of its inner classes, but decided to reuse `CallGraphUpdater` in order to share some of the logic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72226/new/

https://reviews.llvm.org/D72226

Files:
  llvm/include/llvm/Analysis/LazyCallGraph.h
  llvm/include/llvm/Transforms/Utils/CallGraphUpdater.h
  llvm/lib/Analysis/LazyCallGraph.cpp
  llvm/lib/Transforms/Utils/CallGraphUpdater.cpp
  llvm/unittests/Analysis/CGSCCPassManagerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72226.236503.patch
Type: text/x-patch
Size: 6915 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200107/0e5ae98f/attachment.bin>


More information about the llvm-commits mailing list