[PATCH] D72224: [LegalizeVectorOps] Improve handling of multi-result operations.

[Craig Topper via Phabricator via llvm-commits]

craig.topper updated this revision to Diff 236481.
craig.topper added a comment.

-Address review comments.
-Move the Expand/Promote result registration in the cache up to the caller as they need to use "Op" rather than "Node" to update the translation cache. Node almost always points to the same thing as Op, but the UpdateNodeOperands call that assigned Node might trigger CSE. When that happens we still need to use the original Op as the translation cache key since other nodes are holding that reference. This was the bug D71861 <https://reviews.llvm.org/D71861> was trying to fix.
-Add the test case from D71861 <https://reviews.llvm.org/D71861> which tests for that bug in the Custom path.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72224/new/

https://reviews.llvm.org/D72224

Files:
  llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72224.236481.patch
Type: text/x-patch
Size: 28831 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200107/bab1f5fb/attachment-0001.bin>