[PATCH] D72025: [PM][CG-SCC] Add a helper to update the call graph from SCC passes

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/unittests/Analysis/CGSCCPassManagerTest.cpp:1363
+    ASSERT_DEATH(updateCGAndAnalysisManagerForFunctionPass(CG, C, H2N, AM, UR),
+                 "Any new calls should be modeled as");
+  }));
----------------
modocache wrote:
> I think this sentence is missing its ending. Basically `TestUpdateCGAndAnalysisManagerForPasses0` is testing that CGSCC passes can insert new edges, and `TestUpdateCGAndAnalysisManagerForPasses1` is testing that function passes cannot -- is that right?
Yes, correct. The sentence is not an assertion but a regular expression that checks for the assertion.


================
Comment at: llvm/unittests/Analysis/CGSCCPassManagerTest.cpp:1420
+    ASSERT_DEATH(updateCGAndAnalysisManagerForFunctionPass(CG, C, FN, AM, UR),
+                 "Any new calls should be modeled as");
+  }));
----------------
modocache wrote:
> Same as above, this sentence trails off. Tests `TestUpdateCGAndAnalysisManagerForPasses2` and `TestUpdateCGAndAnalysisManagerForPasses3` are testing inserting call edges across SCCs, is that right?
The first tests add edges inside the SCC, the second inside the RefSCC but from an outer SCC to an inner one. Both are trivial so we should be all right adding them and then calling `updateCGAndAnalysisManagerForCGSCCPass`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72025/new/

https://reviews.llvm.org/D72025