[PATCH] D72197: [MC][ELF] Emit a relocation if target is defined in the same section and is non-local

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 6 12:24:11 PST 2020


MaskRay added a comment.

In D72197#1806540 <https://reviews.llvm.org/D72197#1806540>, @jyknight wrote:

> I hope the jmp difference doesn't cause an issue -- I think it makes more sense as you have, but that kind of thing always worries me. :)


I agree that GNU as should treat `jmp weak` as `jmp global`. Some projects noticed problems w/o -ffunction-sections in gcc/binutils and enforced -ffunction-sections to (hopefully) eliminate the issues https://git.musl-libc.org/cgit/musl/commit/?id=27c1eccf33ce5cb7508ef5e541daa9b6441b4a51


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72197/new/

https://reviews.llvm.org/D72197





More information about the llvm-commits mailing list