[PATCH] D72002: GlobalISel: Handle llvm.read_register
Renato Golin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 6 09:10:21 PST 2020
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
In D72002#1806077 <https://reviews.llvm.org/D72002#1806077>, @arsenm wrote:
> The 3 big things SelectionDAG uses for this are in the same category. read_register, write_register and inline asm. The rest doesn't really apply. The alternative is every target needs to implement the exact same string parsing which is unneeded duplication
Right, then perhaps a more strict name would help this not turn into a medusa of left over cases. :)
LGTM, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72002/new/
https://reviews.llvm.org/D72002
More information about the llvm-commits
mailing list