[PATCH] D71743: [ARM][MVE] Enable masked gathers from vector of pointers

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 6 06:51:34 PST 2020


dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVEGatherScatterLowering.cpp:86
+
+bool isLegalAlignment(unsigned NumElements, unsigned ElemSize,
+                      unsigned Alignment) {
----------------
anwel wrote:
> dmgreen wrote:
> > Any function that is only used in this file can be static.
> Do you mean private?
This is global scope I think? So the function can be static. Same for LowerGather below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71743/new/

https://reviews.llvm.org/D71743





More information about the llvm-commits mailing list