[PATCH] D68814: [LV] Allow assume calls in predicated blocks.

[Gil Rapaport via Phabricator via llvm-commits]

gilr added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/predicate-assume.ll:2
+; REQUIRES: asserts
+; RUN: opt -loop-vectorize -force-vector-width=4 -debug -S %s 2>&1 | FileCheck %s
+
----------------
fhahn wrote:
> I've not added a test with calls to assume in the loop header here, because we already have them in llvm/test/Transforms/LoopVectorize/X86/assume.ll.
It would be better to add the new predicated cases to the existing assume.ll.
(Not sure why it resides under X86 - seems it could instead be target independent and force vectorization, but that can be done separately)


================
Comment at: llvm/test/Transforms/LoopVectorize/predicate-assume.ll:10
+
+; CHECK: digraph VPlan {
+; CHECK:  N0 [label =
----------------
gilr wrote:
> Enough to CHECK for VPlan and then CHECK-NOT for the assert?
ping?


================
Comment at: llvm/test/Transforms/LoopVectorize/predicate-assume.ll:39
+
+define void @foo(float* noalias nocapture readonly %a, float* noalias nocapture %b, i32 %n) {
+; CHECK-LABEL: @foo(
----------------
gilr wrote:
> Enough to CHECK for vector.body and then CHECK-NOT for the assert?
ping?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68814/new/

https://reviews.llvm.org/D68814