[PATCH] D72254: MipsDelaySlotFiller: Update registers def-uses for BUNDLE instructions

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 6 05:01:33 PST 2020


arichardson created this revision.
arichardson added a reviewer: atanasyan.
Herald added subscribers: llvm-commits, jrtc27, hiraditya, sdardis.
Herald added a project: LLVM.

In commit b91f239485fb7bb8d29be3e0b60660a2de7570a9 <https://reviews.llvm.org/rGb91f239485fb7bb8d29be3e0b60660a2de7570a9> I updated the
MipsDelaySlotFiller to skip BUNDLE instructions.
However, in addition to not considering BUNDLE instructions for the delay
slot, we also need to ensure that the register def-use information is
updated. Not updating this information caused run-time crashes (when using
the out-of-tree CHERI backend) since later definitions could be overwritten
with earlier register values.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72254

Files:
  llvm/lib/Target/Mips/MipsDelaySlotFiller.cpp
  llvm/test/CodeGen/Mips/delay-slot-filler-bundled-insts-def-use.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72254.236327.patch
Type: text/x-patch
Size: 4593 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200106/fbc9702b/attachment.bin>


More information about the llvm-commits mailing list