[PATCH] D71981: [LLD] [COFF] Don't error out on duplicate absolute symbols with the same value

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/COFF/Symbols.h:232-238
+  bool isEqual(COFFSymbolRef s) const {
+    return va == s.getValue();
+  }
+
+  bool isEqual(uint64_t otherVa) const {
+    return va == otherVa;
+  }
----------------
Instead of adding these member functions, maybe we should just add an accessor `getVA`? It looks like there's no point to hide the actual VA from other classes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71981/new/

https://reviews.llvm.org/D71981