[PATCH] D70350: [DWARF] Allow cross-CU references of subprogram definitions

Fri Jan 3 12:01:17 PST 2020

modocache added a comment.

Just FYI, @vsk, I work on a large codebase that uses Clang to build several projects with (monolithic, not thin) LTO. We have a nightly build that uses LLVM trunk (with some patches internal to us rebased on top) to compile these monolithic LTO projects. Since this patch landed on Dec 20 2019 as rG79daafc9030 <https://reviews.llvm.org/rG79daafc90308787b52a5d3a7586e82acd5e374b3>, each of these LTO builds (>10 in total) began failing during the LTO stage. The stack trace, which I pasted in P8180 <https://reviews.llvm.org/P8180>, seems to indicate there's a problem with debug info, and that's what led me to this diff. I've reverted this diff in our internal LLVM fork, and doing so has our LTO builds succeeding again.

Unfortunately I haven't narrowed down the issue to a reproducible test case, and I can't share the internal projects that are failing. Hopefully the stack trace is useful to you, but if not, let me know if there's anything else I can share! I may not be able to find the time necessary to reduce this to a small test case, but I'd like to help in any other way I can.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70350/new/

https://reviews.llvm.org/D70350