[PATCH] D68298: [GlobalOpt] Pass DTU to removeUnreachableBlocks instead of recomputing.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 4 13:28:27 PST 2020


fhahn added a comment.

In D68298#1804330 <https://reviews.llvm.org/D68298#1804330>, @nikic wrote:

> Yes, we're still on the legacy manager, so DT is not available here. I've just verified that reverting this patch does indeed reclaim a sizable part of the LLVM 10 compile-time regressions (end-to-end timings <https://perf.rust-lang.org/compare.html?start=97588aeda139309169b11654fc809e1ac5fd246c&end=1b6633b46cd7705ec813cfd1cd7083e92f9da903>).


Hm it seems like the legacy module pass manager does not allow using getAnalysisIfAvailable for function analysis :( I've put up D72214 <https://reviews.llvm.org/D72214> with a workaround. Does this fix the regression as well? Otherwise I guess the easiest would be to just revert this patch until the legacy pass manager is gone....


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68298/new/

https://reviews.llvm.org/D68298





More information about the llvm-commits mailing list