[PATCH] D71637: [PatternMatch] Add support for matching ConstantExpr.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 4 00:24:47 PST 2020


lebedev.ri requested changes to this revision.
lebedev.ri added a comment.
This revision now requires changes to proceed.

In D71637#1788905 <https://reviews.llvm.org/D71637#1788905>, @efriedma wrote:

> It looks like we've always matched ConstantExprs for binary operators, but not for other operations.  It probably makes sense to be more consistent.
>
> If we're going to do this, probably makes sense to change OneOps_match/TwoOps_match at the same time.
>
> Can you add testcases for a few of the existing transforms that are changing?  There are too many transforms for it to make sense to cover everything, but it makes sense to illustrate what's actually changing.





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71637/new/

https://reviews.llvm.org/D71637





More information about the llvm-commits mailing list