[PATCH] D72173: [mlir] Fix gcc 5.5 build break

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added a comment.

Pushing a patch that wraps in the namespace as Jacques and River suggested.



================
Comment at: mlir/lib/Dialect/Linalg/Utils/Utils.cpp:101
 template <>
-GenericLoopNestRangeBuilder<loop::ForOp>::GenericLoopNestRangeBuilder(
-    ArrayRef<edsc::ValueHandle *> ivs, ArrayRef<Value> ranges) {
+mlir::edsc::GenericLoopNestRangeBuilder<
+    loop::ForOp>::GenericLoopNestRangeBuilder(ArrayRef<edsc::ValueHandle *> ivs,
----------------
rriddle wrote:
> Have you checked to see if this actually fixes the issue? Last time I ran into this, I had to explicitly wrap the def in:
> 
> namespace ... {
> 
> }
> 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480
I submitted this as a hotpatch and you're right.
Problem is that we can't get easy access to a gcc-5 ..
Jacques tested the wrapper version through docker and it works, sending another hotpatch now. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72173/new/

https://reviews.llvm.org/D72173