[PATCH] D72168: [mlir][Linalg] Add a linalg.reshape op

[Kazuaki Ishizaki via Phabricator via llvm-commits]

kiszk added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.td:72
+    A reassociation is defined as a continous grouping of dimensions and is
+    represented with a affine map array attribute. In the future, non-continous
+    groupings may be allowed (i.e. permutations, reindexings etc).
----------------
nit: `a` -> `an`


================
Comment at: mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:383
+    // there is no relation between dynamic sizes and dynamic strides: we do not
+    // enough information to know whether a "-1" size corresponds to the proper
+    // symbol in the AffineExpr of a stride.
----------------
maybe `enough` -> `have enough`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72168/new/

https://reviews.llvm.org/D72168