[PATCH] D71684: [SPECCPU2017] Add CXXPORTABILITY flags for 526.blender_r

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

In D71684#1793685 <https://reviews.llvm.org/D71684#1793685>, @ychen wrote:

> Thanks for the feedback. Obviously, my CMake skills needs to catch up. My
>  intention was to add the macro definition only for CXX compilation, but
>  `add_definitions`, `add_compile_options` change both C and CXX flags AFAIK at
>  the time.


Does defining `__BOOL_DEFINED` for C as well have any effect? If not, I'd define it for both languages for simplicity.

> N.B. The cmake generator expression used here is not supported for Visual
>  Studio generator which does not need the macro definition. Do we actually care about build this on windows at all?

Many programs in the test-suite are POSIX-specific, e.g. they include `unistd.h`, `sched.h`, etc. I some point I gave up maintaining compatibility headers for windows and just compile the test-suite under WSL.



================
Comment at: External/SPEC/CFP2017rate/526.blender_r/CMakeLists.txt:17
+  -funsigned-char
+  $<$<COMPILE_LANGUAGE:CXX>:-D__BOOL_DEFINED>
 )
----------------
Did you consider using `add_compile_options` just for the generator-expression and keep the other as-is? We can do a clean-up once we raise the cmake requirement such that we can use `add_compile_definitions`.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71684/new/

https://reviews.llvm.org/D71684