[PATCH] D72155: [DebugInfo] Make incorrect debug line extended opcode length non-fatal

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 3 07:37:01 PST 2020


jhenderson created this revision.
jhenderson added reviewers: ikudrin, probinson, JDevlieghere, dblaikie, MaskRay.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

It is possible to try to keep parsing a debug line program even when the length of an extended opcode does not match what is expected for that opcode. This patch changes what was previously a fatal error to be non-fatal. The parser now continues by assuming the larger of the claimed length and parsed length is correct.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72155

Files:
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/test/tools/llvm-dwarfdump/X86/Inputs/debug_line_malformed.s
  llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
  llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72155.236060.patch
Type: text/x-patch
Size: 10866 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200103/3e1863e3/attachment.bin>


More information about the llvm-commits mailing list