[PATCH] D68411: Add support for intrinsics llvm.ppc.dcbfl and llvm.ppc.dcbflp

Fri Jan 3 05:38:46 PST 2020

nemanjai added a comment.

In D68411#1722968 <https://reviews.llvm.org/D68411#1722968>, @anil9 wrote:

> In D68411#1718116 <https://reviews.llvm.org/D68411#1718116>, @lei wrote:
>
> > Since these are just mnemonics for using dcbf, why not just add the tests to llvm/test/CodeGen/PowerPC/dcbf.ll instead of creating 2 small test files.
>
>
> These are mnemonics true, but we have separate intrinsics for them as opposed to using one intrinsic with different constants and also the assembly code is different. 
>  I think having multiple files gives more structure and in theory reduces chances of merge conflicts.

I second Lei's suggestion to combine the test cases. As lightweight as LIT test cases are, there are already nearly 60k of them and there is a non-zero cost to running additional ones. So if there is no compelling reason to add multiple test cases, we should opt to combine them. And I don't see a compelling reason to separate these.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68411/new/

https://reviews.llvm.org/D68411