[PATCH] D72109: [cmake] Use relative cmake binary dir for processing pass plugins

[serge via Phabricator via llvm-commits]

serge-sans-paille added inline comments.


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:907
+  execute_process(COMMAND ${CMAKE_COMMAND} -E copy_if_different
+    "${CMAKE_CURRENT_BINARY_DIR}/include/llvm/Support/Extension.def.tmp"
+    "${CMAKE_CURRENT_BINARY_DIR}/include/llvm/Support/Extension.def")
----------------
Why `CMAKE_CURRENT_BINARY_DIR` and not `LLVM_BINARY_DIR` as in line 903?


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:909
+    "${CMAKE_CURRENT_BINARY_DIR}/include/llvm/Support/Extension.def")
+  file(REMOVE "${CMAKE_CURRENT_BINARY_DIR}/include/llvm/Support/Extension.def.tmp")
 endfunction()
----------------
Same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72109/new/

https://reviews.llvm.org/D72109