[PATCH] D71829: [PowerPC] Exploit the rlwinm instructions for "and" with constant.

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 20:35:00 PST 2020


amyk added a comment.

Just curious about a specific portion of your patch, so I posted a comment.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:4460
+
+    // It is not 16-bit imm that means we need two instructions at least if
+    // using "and" instruction. Try to exploit it with rotate mask instructions.
----------------
Might be a silly question, but what exactly does this comment mean and why is a 16-bit immediate significant? And did you mean to say, `If it is not a 16-bit imm`? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71829/new/

https://reviews.llvm.org/D71829





More information about the llvm-commits mailing list