[PATCH] D71957: [llvm-size] print a blank line between archieve members when using sysv format

Jim Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 18:16:11 PST 2020


Jim added inline comments.


================
Comment at: llvm/tools/llvm-size/llvm-size.cpp:580
+    return;
   } else if (MachOUniversalBinary *UB =
                  dyn_cast<MachOUniversalBinary>(&Bin)) {
----------------
MaskRay wrote:
> Delete `else` and add a new line as you added `return` above.
I think this change is not needed. If you delete line 842-844.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71957/new/

https://reviews.llvm.org/D71957





More information about the llvm-commits mailing list