[PATCH] D72098: [mlir][Linalg] NFC - Reimplement getStridesAndOffset

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added a comment.

@rriddle I am not concerned because the heavy cases involve the introduction of local variables that come from divisions/modulo and FourierMotzkin.
Concretely I do not see a measurable effect when running the tests.

There are 2 additional orthogonal aspects:

1. I proposed in the past that we have a very strict type layering of AffineExpr to prevent people from accidentally pulling in expensive computations silently. This was rejected at the time but is probably due for a refresh now.
2. Since we're uniquing properly, at some point it will make sense to cache the a map<AffineExpr, simplied AffineExpr>, I had done some measurements more than a year ago and a good 75% of invocations were redundant.

These are low-pri for me to the overall trajectory but if they become problematic they should of course be addressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72098/new/

https://reviews.llvm.org/D72098