[PATCH] D72095: [mlir][spirv] Update SPIR-V enums and ops with availability spec

[Mahesh Ravishankar via Phabricator via llvm-commits]

mravishankar accepted this revision.
mravishankar added a comment.
This revision is now accepted and ready to land.

This is awesome! Fantastic work!



================
Comment at: mlir/utils/spirv/gen_spirv_dialect.py:141
 
-def gen_operand_kind_enum_attr(operand_kind):
+def get_cap_mapping(operand_kinds):
+  """Returns the capability mapping from duplicated cases to their canonicalized
----------------
Nit: rename this "get_capability_mapping". Just makes it clearer


================
Comment at: mlir/utils/spirv/gen_spirv_dialect.py:400
 
+  cap_mapping = get_cap_mapping(operand_kinds)
+
----------------
Nit: use "capability_mapping" for variable name?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72095/new/

https://reviews.llvm.org/D72095