[PATCH] D72094: [mlir][linalg] Lower linalg to affine loops

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 10:26:56 PST 2020


nicolasvasilache accepted this revision.
nicolasvasilache added subscribers: ftynse, mravishankar, AlexEichenberger.
nicolasvasilache added a comment.
This revision is now accepted and ready to land.

Looks great and is as simple as it should be, thanks!
Accepting conditioned on the nit above.

cc @ftynse @AlexEichenberger @mravishankar



================
Comment at: mlir/lib/Dialect/Linalg/Utils/Utils.cpp:116
+    auto rangeOp = cast<RangeOp>(range.getDefiningOp());
+    auto lb = rangeOp.min();
+    auto ub = rangeOp.max();
----------------
please fold these 3 defs into their uses


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72094/new/

https://reviews.llvm.org/D72094





More information about the llvm-commits mailing list