[PATCH] D72067: [PowerPC] Delete PPCSubtarget::isDarwin and isDarwinABI

Thu Jan 2 09:40:09 PST 2020

MaskRay added a comment.

In D72067#1801141 <https://reviews.llvm.org/D72067#1801141>, @nemanjai wrote:

> The code you are modifying should be unreachable and should be safe to remove. However, can you please provide a description with some rationale about why you are removing this now. Namely, is there a pressing concern to get this removed soon or is this just a regular cleanup?
>
> The reason I am asking is that we have started the work to remove all Darwin code from the PPC back end but have paused it for now as there are situations where the ongoing AIX implementation benefits from seeing how things were handled in Darwin due to some ABI similarities. Of course, this is convenience rather than necessity, so if you have some reason that necessitates removal of this code now, that definitely trumps the reasons I outlined above.
>
> In any case, I am adding @cebowleratibm to the review as he is much more familiar with AIX concerns.

No pressing concern. This is only a regular cleanup. Added the discussion to the summary.

>From http://lists.llvm.org/pipermail/llvm-dev/2018-August/125614.html

> - it looks like we're all now in agreement to move forward.

The remaining Darwin PPC code is for its reference purposes. As you can see from this patch, the code now has no test. Let's wait for @cebowleratibm's opinions.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72067/new/

https://reviews.llvm.org/D72067