[PATCH] D71766: [llvm-readobj/llvm-readelf][test] - Add testing for EI_OSABI and EI_ABIVERSION fields of an ELF header.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 04:24:56 PST 2020


jhenderson added a comment.

Two post-commit nits, otherwise this was fine, thanks!



================
Comment at: llvm/test/tools/llvm-readobj/ELF/file-header-abi-version.test:1
+## This is a test to test how ABI version (EI_ABIVERSION) of an ELF file header is dumped.
+
----------------
how the ABI version field


================
Comment at: llvm/test/tools/llvm-readobj/ELF/file-header-os-abi.test:1
+## This is a test to test how OS/ABI identification (EI_OSABI) of an ELF file header is dumped.
+
----------------
how the OS/ABI


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71766/new/

https://reviews.llvm.org/D71766





More information about the llvm-commits mailing list