[PATCH] D72069: [NFC] Add explicit instantiation to releaseNode

[Kai Luo via Phabricator via llvm-commits]

lkail added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineScheduler.h:762
+  void releaseNode(SUnit *SU, unsigned ReadyCycle, unsigned Idx = 0) {
+    releaseNodeImpl(SU, ReadyCycle, Idx, InPQueue);
+  }
----------------
DoktorC wrote:
> lkail wrote:
> > I think adding an `Impl` method might break origin author's intention. With a template parameter, compiler can remove some dead branches at compile time.
> You got the point @lkail. For a (verbose) explanation of my intent, refer to my last comment
> https://reviews.llvm.org/D65506#1800921
But to clarify, I'm not a fan of separating template's def and decl, since it's ABI error-prone. I would let other decide what is an proper implementation here, considering code standard of LLVM doesn't limit scope of using template.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72069/new/

https://reviews.llvm.org/D72069