[PATCH] D71957: [llvm-size] print a blank line between archieve members when using sysv format

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 00:44:28 PST 2020


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-size/archive.test:50
 # SYSV-3-EMPTY:
+# SYSV-3-EMPTY:
+# SYSV-3-EMPTY:
----------------
TH3CHARLie wrote:
> MaskRay wrote:
> > GNU size prints 2 blank lines.
> I believe this is necessary, see `radix.test`'s case 4-6
`--format=sysv` prints exactly two blank lines between two blocks. Your patch currently prints 3.

After you fix this, you may need to provide `git commit --amend --author "what-is-your-name <what-is at your-email>"`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71957/new/

https://reviews.llvm.org/D71957





More information about the llvm-commits mailing list