[PATCH] D72022: [mlir][Linalg] Extend generic ops to allow tensors

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:187
   if (funType.getNumInputs() != nViews + nLoops)
-    return op.emitError(
         "op expected fun arguments to match number of views + number of loops");
----------------
All of this cleanup seems unrelated to this revision. It would be easier to review if you moved such changes out.


================
Comment at: mlir/tools/mlir-tblgen/RewriterGen.cpp:577
+      if (resultTree.isNativeCodeCall()) {
+        os << symbolInfoMap.getAllRangeUse(
+            val, "SmallVector<Value, 4> values{0};", "\n");
----------------
nicolasvasilache wrote:
> rriddle wrote:
> > It isn't immediately clear to me why this is necessary. What return value is convertible to small vector, but not ArrayRef for example?
> Reworked and added a comment.
Could you use ValueRange instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72022/new/

https://reviews.llvm.org/D72022