[PATCH] D70590: [Examples] Add add_llvm_example_library macro and use it for IR example.

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 1 16:47:44 PST 2020


compnerd added a comment.

Hmm, I see, yes, that would change the behavior where we would not create the targets for it.  In that case, using `EXCLUDE_FROM_ALL` is fine, but set it as a target property rather than passing global variables like this.  But, even better would be to understand if we even need this.

Really, the `install-distribution` target allows the installed image to contain specific bits, and the `distribution` target lets you build the minimal set.  Having the target being built always when you build *everything* (ALL) is the preferable option.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70590/new/

https://reviews.llvm.org/D70590





More information about the llvm-commits mailing list