[PATCH] D72019: [X86] Use carry flag from add for (seteq (add X, -1), -1).

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:21692
+    // the node alone and emit a 'cmp' instruction.
+    auto CheckAddUsers = [](SDValue Op) {
+      for (SDNode::use_iterator UI = Op.getNode()->use_begin(),
----------------
Make this a static helper, so we're not duplicating the code in EmitTest()?
Also, can use a for-range loop?
  for (SDNode *User : Op->uses())



================
Comment at: llvm/test/CodeGen/X86/pr44412.ll:29-30
   tail call void @foo(i32 %6)
   %7 = icmp eq i32 %6, 0
   br i1 %7, label %8, label %4
 
----------------
Add the sibling test to produce 'jae' by inverting the icmp or the branch labels?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72019/new/

https://reviews.llvm.org/D72019