[PATCH] D69701: [Utils] Allow "on-the-fly" argument changes for update_test_check scripts

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 31 01:20:45 PST 2019


jdoerfert added a comment.

In D69701#1799763 <https://reviews.llvm.org/D69701#1799763>, @arichardson wrote:

> If I understand this correctly existing check lines between off/on directives should be copied verbatim. Could you add one (that does not match the auto-generated content) to the disabled part of the test?


Will do.

> Maybe better to add a action=store_true and a action=store_false booleanoption with the same dest=. Maybe --turn-on/--turn-off or simply --enable/--disable?

I'll look into that and update the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69701/new/

https://reviews.llvm.org/D69701





More information about the llvm-commits mailing list