[PATCH] D72017: [Attributor] AANoRecurse check all call sites for `norecurse`

[Hideto Ueno via Phabricator via llvm-commits]

uenoku added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1935
+      if (AllCallSitesKnown)
+        indicateOptimisticFixpoint();
+      return ChangeStatus::UNCHANGED;
----------------
jdoerfert wrote:
> uenoku wrote:
> > Don't we need to return?
> We return in the next line either way. If the `checkForAllCallSites` returned true we can *at least* assume `noreturn`. Or did I misunderstand your question?
I mean we need to return `ChangeStatus::CHANGED` here, isn't it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72017/new/

https://reviews.llvm.org/D72017