[PATCH] D72014: [PowerPC]: Add powerpcspe target triple subarch component

Mon Dec 30 19:27:34 PST 2019

jhibbits marked an inline comment as done.
jhibbits added inline comments.

================
Comment at: clang/test/Preprocessor/init.c:7628
+// PPC32-SPE-TGT:#define __SPE__ 1
 // 
 // RUN: %clang_cc1 -E -dM -ffreestanding -triple=powerpc-unknown-linux-gnu -target-cpu 8548 < /dev/null | FileCheck -match-full-lines -check-prefix PPC8548 %s
----------------
arichardson wrote:
> These seem to be checking the same defines. It's it possible to reuse the existing `-check-prefix PPC32-SPE` for new newly added command?
Yeah, it's better to reuse.  I waffled on it a bit before doing it this way, and didn't really like it anyway.  Reverting to the reuse.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72014/new/

https://reviews.llvm.org/D72014