[PATCH] D71885: [PowerPC] replace rlwinm operand 1 with src rlwinm operand 1

qshanz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 30 02:14:29 PST 2019


steven.zhang added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/fold-rlwinm.mir:137
+    ; CHECK-NOT: %2:gprc
     %3:gprc = RLWINMo %2:gprc, 8, 5, 10, implicit-def $cr0
+    ; CHECK: %3:gprc = ANDIo %1, 0, implicit-def $cr0
----------------
steven.zhang wrote:
> Why the RLWINMo is still here ?
Ah, sorry. I didn't notice that, you are replacing it with ANDIo. So, it is fine. But I still don't agree with checking the symbol register number which is vulnerable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71885/new/

https://reviews.llvm.org/D71885





More information about the llvm-commits mailing list